Asset manager delete problems
Hi @duskhacker, I was able to recreate the issue of the onClick event firing when clicking on the X (jsfiddle in case anyone else cares to see it: https://jsfiddle.net/8v946q4b/3/). Sorry I don't have a lot of time to debug this myself at the moment (I may have time to research this tomorrow if you're still having tro...
Read full answer below ↓Question
In the Asset Manager, when the x to remove an asset is clicked, it appears to fire both the onDelete event AND the onClick event. This puts the asset you just deleted into the target. Furthermore, one cannot click another asset to replace it in the target until you close the asset manager window and re-open it.
If the user is not very careful, they can get the document into an inconsistent state that will not load properly from the server.
Any pointers on how to fix this are welcome.
Answers (3)
Hi @duskhacker,
I was able to recreate the issue of the onClick event firing when clicking on the X (jsfiddle in case anyone else cares to see it: https://jsfiddle.net/8v946q4b/3/). Sorry I don't have a lot of time to debug this myself at the moment (I may have time to research this tomorrow if you're still having trouble), but it appears to me to be a bug that should get fixed in the AssetImageView object. I see the onRemove method starts by calling e.stopPropagation(), which I believe is attempting to prevent the onClick method from firing, but that doesn't appear to be working if that is indeed the intent. My guess is that onClick is firing before onRemove for some reason, but I'm not sure this is the case nor why that would be happening.
I may have time to research this tomorrow if you're still having trouble
@ryandeba Thanks for the followup! This is one of my outstanding problems with GrapesJS. I know I'm not going to be able to fix it in a reasonable time-frame, I'm not familiar with the code-base enough to debug effectively so I'll have to rely on your expertise. Currently, it is not a show-stopper I have lots of stuff to do before this goes into production. But if it can be fixed in the coming days that would be great!
@duskhacker - I've submitted a pull request that should fix this bug
Related Questions and Answers
Continue research with similar issue discussions.
Issue #1854
Asset manager empty on second open
Hi, I am trying to build a plugin which sets up the asset manager as a SVG repository. If the user selects a SVG, the asset manager opens....
Issue #497
Asset manager
hi @artf , is it possible to replace current asset manager , from my custom one? I have created my own asset manager , i want to use that t...
Issue #1078
add custom date time picker for countdown
For countdown we would like to add our custom datetime picker not just the html one.We tried adding click event in its trait this way trait...
Issue #1805
Define new Image component
I'm new to GrapesJs and am unable to figure out how to create an image component. For example, I have an img tag and have defined the src ,...
Paid Plugins That Match This Issue
Curated by issue keywords and label relevance to help you ship faster.
Loading paid plugin recommendations...
Check the open-source GrapesJS plugins on GitHub or run a quick search in our free catalog.
Browse free plugins →Premium plugins ship with support, regular updates, and production-ready features — save days of integration work.
Browse premium plugins →Related tutorials
In-depth guides on the same topic.
Browse Plugin Categories
Jump directly to plugin category pages on the marketplace.